6.0: [SILGen] Forward address-only self to borrowing accessors. #74269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize and expand the pre-existing peephole. rdar://127115078
|
@swift-ci please test |
nate-chandler
changed the title
tbkka
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix a consume-address-checker diagnose-on-valid.
Previously, when emitting an accessor for a copyable, address-only value, a temporary was always created and a copy always made into it. That was true even when the accessor only borrowed the base. The result was that calling a
borrowingaccessor on a guaranteed value (like aborrowingparameter) resulted in a bad diagnostic'x' is borrowed and cannot be consumed.Here, this is fixed by avoiding the temporary when calling an accessor on a guaranteed, address-only value. Instead the existing address is passed along directly.
Scope: Affects calls to accessors of copyable values.
Issue: rdar://127115078
Original PR: #74235
Risk: Low.
Testing: Added and updated tests.
Reviewer: Joe Groff ( @jckarter )